Resolve conflict with other plugin frameworks when hooking ProcessUserCmds #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rCmds Delay detouring ProcessUserCmds until after other plugin/frameworks have had a chance to hook it, such as CS2Fixes. If some other plugin hooked it, then use a fallback input method. This fallback method is subpar in that: - It does not prevent weapon switching when number keys bound - It does not freeze the player in place when using WASD input As it stands, just delaying hooking results in a successful hook by CS# too, so this may let both work together. In any case, if the signature is not found then the fallback method is selected, and is sufficient Fixes #12
AshleighAdams
force-pushed
the
process-user-cmds-fallback
branch
from
752b83f to
34e90bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay detouring ProcessUserCmds until after other plugin/frameworks have had a chance to hook it, such as CS2Fixes. If some other plugin hooked it, then use a fallback input method.
This fallback method is subpar in that:
As it stands, just delaying hooking results in a successful hook by CS# too, so this may let both work together. In any case, if the signature is not found then the fallback method is selected, and is sufficient
Fixes #12