Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions and changes #103

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vincenzocoia
Copy link

This pull request comes with three changes:

  1. A modified version of ch_regime_plot() (ch_regime_plot2()) so as not to depend on a specific data frame format as an input.
    • For example, can't easily use the original function if data are retrieved from tidyhydat.
  2. A function I like using called ch_ams_timeseries() to visualize a time series of annual maxima. Especially useful for making implicit NA's explicit, so that the line plot breaks when data for a year is missing.
  3. A scale_*_gumbel*() family of functions meant to be added to a ggplot object to put return period or AEP on reduced Gumbel variate spacing.

Regarding the regime plot, this is meant to generate a discussion regarding what to do about this new way of engaging with the function, especially since other plotting functions have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant