Skip to content

Conversation

@huard
Copy link
Collaborator

@huard huard commented May 6, 2024

Fixed custom output command not rendering correctly
Convert config and output paths to absolute paths

Copy link
Member

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link

Coverage Status

coverage: 81.67% (-0.09%) from 81.756%
when pulling 8f9aa15 on fix_custom_output
into e60d704 on master.

@tlvu
Copy link
Collaborator

tlvu commented May 6, 2024

Is this PR compatible with the current Jupyter env and can be merged immediately or this PR is only for the upcoming Jupyter env and have to wait for that one to go live before this PR can be merged?

If this is for the upcoming Jupyter env only, can this PR be merged to the branch fixnbs_pavics_betaimage (#356) from Travis so I can test all upcoming changes together?

@huard
Copy link
Collaborator Author

huard commented May 7, 2024

It's a bugfix that I believe is compatible with the current env.

@huard huard merged commit 829a5ec into master May 7, 2024
@huard huard deleted the fix_custom_output branch May 7, 2024 12:57
Zeitsperre pushed a commit that referenced this pull request May 7, 2024
…nd output paths to absolute paths. (#360)

# Conflicts:
#	HISTORY.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants