[feat] #118 Add port request table#119
Merged
saokiritoni merged 5 commits intodevelopfrom Sep 2, 2025
Merged
Conversation
…ortRequests.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new entity for managing port requests in the admin backend system. The implementation creates a database table to track port allocation requests with associated metadata.
- Introduces
PortRequestsentity with port number validation and usage tracking - Establishes relationship with existing
Requestentity through foreign key - Implements standard JPA entity patterns with Lombok annotations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+23
to
+24
| @Column(name = "port_number", nullable = false, unique = true) | ||
| @Min(1) |
There was a problem hiding this comment.
Port number validation allows port 1-1023 which are system/well-known ports typically reserved for system services. Consider using @min(1024) to restrict to user/dynamic ports unless system ports are intentionally required.
Suggested change
| @Column(name = "port_number", nullable = false, unique = true) | |
| @Min(1) | |
| @Min(1024) |
saokiritoni
approved these changes
Sep 2, 2025
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| @Column(name = "id") | ||
| private Long id; |
Member
There was a problem hiding this comment.
다른 id 값 형식이랑 맞춰야 해서 길어지더라도 portRequestId 로 바꾸는 게 좋을 거 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈