Skip to content

Comments

[feat] #118 Add port request table#119

Merged
saokiritoni merged 5 commits intodevelopfrom
feat/#118-add-port-request-table
Sep 2, 2025
Merged

[feat] #118 Add port request table#119
saokiritoni merged 5 commits intodevelopfrom
feat/#118-add-port-request-table

Conversation

@kwdahun
Copy link
Contributor

@kwdahun kwdahun commented Aug 31, 2025

@kwdahun kwdahun requested review from Copilot and saokiritoni August 31, 2025 07:11
@kwdahun kwdahun self-assigned this Aug 31, 2025
@kwdahun kwdahun requested a review from a team as a code owner August 31, 2025 07:11

This comment was marked as outdated.

@kwdahun kwdahun requested a review from Copilot September 2, 2025 12:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new entity for managing port requests in the admin backend system. The implementation creates a database table to track port allocation requests with associated metadata.

  • Introduces PortRequests entity with port number validation and usage tracking
  • Establishes relationship with existing Request entity through foreign key
  • Implements standard JPA entity patterns with Lombok annotations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +23 to +24
@Column(name = "port_number", nullable = false, unique = true)
@Min(1)
Copy link

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port number validation allows port 1-1023 which are system/well-known ports typically reserved for system services. Consider using @min(1024) to restrict to user/dynamic ports unless system ports are intentionally required.

Suggested change
@Column(name = "port_number", nullable = false, unique = true)
@Min(1)
@Min(1024)

Copilot uses AI. Check for mistakes.
Copy link
Member

@saokiritoni saokiritoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
@Column(name = "id")
private Long id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 id 값 형식이랑 맞춰야 해서 길어지더라도 portRequestId 로 바꾸는 게 좋을 거 같아요!

@saokiritoni saokiritoni merged commit edbb3f0 into develop Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Add port usage table per request (PortRequests table)

2 participants