[fix] #137 fix change request fetch error#138
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a type casting error in the change request fetch endpoint that was causing incorrect response handling.
- Replaces incorrect explicit type casting with proper SuccessResponse factory method
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| public ResponseEntity<SuccessResponse<?>> getChangeRequests() { | ||
| List<ChangeRequestResponseDTO> changeRequests = adminRequestQueryService.getChangeRequests(); | ||
| return ResponseEntity.ok((SuccessResponse<?>) changeRequests); | ||
| return SuccessResponse.ok(changeRequests); |
There was a problem hiding this comment.
The return type should be ResponseEntity<SuccessResponse<?>> but SuccessResponse.ok() likely returns SuccessResponse<?>. You need to wrap it with ResponseEntity.ok() to match the method signature: return ResponseEntity.ok(SuccessResponse.ok(changeRequests));
Suggested change
| return SuccessResponse.ok(changeRequests); | |
| return ResponseEntity.ok(SuccessResponse.ok(changeRequests)); |
saokiritoni
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
서버 정보 변경 신청도 포트 추가 기능 넣고 수정중