Skip to content

Comments

[fix] #137 fix change request fetch error#138

Merged
kwdahun merged 1 commit intodevelopfrom
fix/#137-change-request-fetch-error
Sep 17, 2025
Merged

[fix] #137 fix change request fetch error#138
kwdahun merged 1 commit intodevelopfrom
fix/#137-change-request-fetch-error

Conversation

@kwdahun
Copy link
Contributor

@kwdahun kwdahun commented Sep 16, 2025

🌱 관련 이슈

서버 정보 변경 신청도 포트 추가 기능 넣고 수정중

@kwdahun kwdahun self-assigned this Sep 16, 2025
@kwdahun kwdahun requested a review from a team as a code owner September 16, 2025 10:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a type casting error in the change request fetch endpoint that was causing incorrect response handling.

  • Replaces incorrect explicit type casting with proper SuccessResponse factory method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

public ResponseEntity<SuccessResponse<?>> getChangeRequests() {
List<ChangeRequestResponseDTO> changeRequests = adminRequestQueryService.getChangeRequests();
return ResponseEntity.ok((SuccessResponse<?>) changeRequests);
return SuccessResponse.ok(changeRequests);
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be ResponseEntity<SuccessResponse<?>> but SuccessResponse.ok() likely returns SuccessResponse<?>. You need to wrap it with ResponseEntity.ok() to match the method signature: return ResponseEntity.ok(SuccessResponse.ok(changeRequests));

Suggested change
return SuccessResponse.ok(changeRequests);
return ResponseEntity.ok(SuccessResponse.ok(changeRequests));

Copilot uses AI. Check for mistakes.
@kwdahun kwdahun merged commit 69a849d into develop Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] Fetching change request logic error

2 participants