[fix] #93 Edit user dashboard API & Add response data for admin request management pannel#99
Merged
saokiritoni merged 4 commits intodevelopfrom Aug 24, 2025
Merged
Conversation
…st management pannel
saokiritoni
reviewed
Aug 23, 2025
| .build(); | ||
| } | ||
| } | ||
| public static SaveRequestResponseDTO fromEntity(Request request) { |
Member
There was a problem hiding this comment.
fromEntity에 원래 null 관련 처리가 되어있었는데
이런 처리들은 service에 모아서 예외처리를 해주는 게 더 좋을 것 같습니다!
지금 서비스에서 비즈니스 예외를 다 다루고 있기도 하고,
DTO에서 이런 처리를 해주는 게 '데이터를 담는다'는 의미를 해치는 것 같아서...
ErrorCode가 아니라 이렇게 조건 달아서 null을 줄줄이 처리하다보면 어디서 에러났는지도 잘 안 잡힐 거 같고요!
요건 원래 이렇게 되어있었어서 좀 고민해보면 좋을 것 같습니당!!
물론 지금도 잘 작동한다면 굿!
Member
|
위에 거만 나중에 고치면 더 좋을 것 같아요! |
saokiritoni
approved these changes
Aug 23, 2025
Contributor
Author
|
validateAndConvertToDTO 함수로 빼서 service layer에 집어넣었어! 시간되면 검토해보고 답글 하나만 달아줘! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈