Bug fixes on the different field types handling

CSLTech · Mar 12, 2024 · 9f7a7a3 · 9f7a7a3
1 parent f7da500
commit 9f7a7a3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "json-editor",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "JSON Editor (based on https://github.com/josdejong/svelte-jsoneditor)",
   "license": "MIT",
   "svelte": "index.js",

diff --git a/schema.json b/schema.json
@@ -12,7 +12,7 @@
         "key": "fieldType",
         "label": "Field Type",
         "options": [{"label": "String", "value": "text"}, {"label": "JSON", "value": "json"}],
-        "defaultValue": "String",
+        "defaultValue": "text",
         "required": true
       },
       {

diff --git a/src/Component.svelte b/src/Component.svelte
@@ -30,7 +30,6 @@
         }
 
         if (fieldType !== 'text' &&  fieldType !== 'json') {
-            console.log(fieldText, fieldJSON);
             configErrors = configErrors + "Select a field type\n";
         }
 
@@ -59,18 +58,18 @@
     $: formStep = formStepContext ? $formStepContext || 1 : 1;
     $: labelClass = labelPos === "above" ? "" : `spectrum-FieldLabel--${labelPos}`;
 
-    $: if (formApi && (fieldText || fieldJSON)) {
+
+    $: if (formApi && (fieldText || fieldJSON) && !configErrors) {
         const formField = formApi.registerField(
             getField(),
             fieldType,
             defaultValue,
             false,
-            readOnly,
             validationText,
             formStep
         );
 
-        unsubscribe = formField.subscribe((value) => {
+        unsubscribe = formField?.subscribe((value) => {
             fieldState = value?.fieldState;
             fieldApi = value?.fieldApi;
         });