Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional args to ssh deployment for docker run arguments #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pl4nty
Copy link
Contributor

@pl4nty pl4nty commented Mar 6, 2023

In my case, this allowed adding Linux capabilities to run nsjail for TCP-based pwn chals.

@ColdHeat
Copy link
Member

So I thought about this for awhile and I think this is possibly going in the wrong direction. Ideally everything needed to deploy a challenge should be in challenge.yml. I realize that currently sometimes that's not the case but I think it's the goal to strive for. Perhaps it makes sense to put deploy args somewhere in challenge.yml?

@pl4nty
Copy link
Contributor Author

pl4nty commented Mar 15, 2023

@ColdHeat that makes sense, I've swapped it for deploy_args in challenge.yml and updated the example. Currently only supports SSH deployments (docker run [deploy_args]), but this design could allow args for registry/cloud deployments if that's needed in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants