Skip to content

Deploy all shouldn't error if a challenge image is null/empty #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

Deploy all shouldn't error if a challenge image is null/empty #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ctfcli/cli/challenges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,14 +711,14 @@ def deploy(
else:
challenges = self._resolve_all_challenges()

deployable_challenges, failed_deployments, failed_syncs = [], [], []
deployable_challenges, failed_deployments, skipped_deployments, failed_syncs = [], [], [], []

# get challenges which can be deployed (have an image)
for challenge_instance in challenges:
if challenge_instance.get("image"):
deployable_challenges.append(challenge_instance)
else:
failed_deployments.append(challenge_instance)
skipped_deployments.append(challenge_instance)

config = Config()
with click.progressbar(deployable_challenges, label="Deploying challenges") as challenges:
Expand Down Expand Up @@ -815,9 +815,14 @@ def deploy(

click.secho("Success!\n", fg="green")

if len(skipped_deployments) > 0:
click.secho("Deployment skipped (no image specified) for:",fg="yellow")
for challenge_instance in skipped_deployments:
click.echo(f" - {challenge_instance}")

if len(failed_deployments) == 0 and len(failed_syncs) == 0:
click.secho(
"Success! All challenges deployed and installed or synced.",
"Success! All deployable challenges deployed and installed or synced.",
fg="green",
)
return 0
Expand Down