Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c18n: Enable -morello-bounded-memargs for purecap userland #141

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

dpgao
Copy link

@dpgao dpgao commented Jan 23, 2024

The cc script will use this flag by default starting with the next CheriBSD release.

@kwitaszczyk
Copy link
Member

This is blocked by CTSRD-CHERI/cheribsd#1981.

@brooksdavis
Copy link
Member

This needs to bump PORTREVISION

@dpgao
Copy link
Author

dpgao commented Mar 14, 2024

This needs to bump PORTREVISION

Do you mean PORTVERSION instead?

@brooksdavis
Copy link
Member

This needs to bump PORTREVISION

Do you mean PORTVERSION instead?

Indeed. Usually this sort of thing is PORTREVISION based, but not in this case.

@kwitaszczyk I wonder if we should change this PORTVERSION to be a date (e.g. 20240315)?

@kwitaszczyk
Copy link
Member

@kwitaszczyk I wonder if we should change this PORTVERSION to be a date (e.g. 20240315)?

I guess the date-based format might be easier to maintain as it'd be quite noticeable if llvm-bases used an old date despite of known later changes. Also, it might be helpful when correlating versions of llvm-base and llvm-morello as llvm-morello already includes a date in its version format.

These are not strong arguments but for sure I cannot see any disadvantages of the date-based format. I think we can switch to it.

And bump PORTVERSION.

The `cc` script will use this flag by default starting with the CheriBSD
24.04.
@kwitaszczyk kwitaszczyk merged commit c05ab00 into main Mar 16, 2024
@kwitaszczyk kwitaszczyk deleted the dpgao-patch-1 branch March 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants