stop and scan all procs sharing a vmspace #1640
Draft
+220
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksdavis
force-pushed
the
caprevoke-unmapped-single
branch
3 times, most recently
from
dc1bd41
to
8fd603e
Compare
brooksdavis
force-pushed
the
caprevoke-all-procs-in-vmspace
branch
from
9551da8
to
725711c
Compare
brooksdavis
changed the base branch from
caprevoke-unmapped-single
to
caprevoke
brooksdavis
force-pushed
the
caprevoke-all-procs-in-vmspace
branch
from
725711c
to
c9a0591
Compare
brooksdavis
force-pushed
the
caprevoke-all-procs-in-vmspace
branch
from
c9a0591
to
baa179c
Compare
This will allow us to efficently act on all processes sharing a vmspace (important with co-processes).
stop_vmspace_proc() and resume_vmspace_proc() respectively stop and resume all processes but curproc associated with the vmspace of a given process. Functionally this the same a (stop|resume)_all_proc() except that it walks the vmspace process list rather than allproc. For each process use a new thread_single(SINGLE_VMSPACE) which acts like SINGLE_BOUNDRY except that like SINGLE_ALLPROC it suspends all threads in the process and does not expect proc to be curproc.
In addition to thread_single() on the revoking process, call stop_vmspace_proc() to stop all other processes that share our vmspace. Then revoke the horders for each thread and process sharing the vmspace.
brooksdavis
force-pushed
the
caprevoke-all-procs-in-vmspace
branch
from
baa179c
to
159c084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A drafty and certainly somewhat broken first cut that doesn't immediatly blow up under current tests.
In addition to thread_single() on the revoking process, add stop_vmspace_proc() which stops all other processes that share our vmspace. It's a lightly modified copy of stop_all_proc() and walks the allproc list to find processes to suspend and repeats until there's no process left to suspend.
Known issues: