Guard -D_LIBUNWIND_SANDBOX_OTYPES behind an aarch64 check #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, this file shouldn't really have been messed about with until also landing the changes to libunwind itself |
jrtc27
reviewed
Jun 5, 2024
lib/libgcc_s/Makefile
Outdated
| @@ -54,6 +54,10 @@ SRCS+= s_scalbnl.c | |||
| .endif | |||
|
|
|||
| SYMBOL_MAPS+= ${.CURDIR}/Symbol-c18n.map | |||
There was a problem hiding this comment.
What would the best way to check for this be? The rtld Makefile seems to check for purecap + aarch64. Is that sufficient?
dstolfa
force-pushed
the
libgccs-aarch64-only
branch
2 times, most recently
from
0376053 to
d57e168
Compare
brooksdavis
approved these changes
Jun 5, 2024
dstolfa
force-pushed
the
libgccs-aarch64-only
branch
from
d57e168 to
ea5851b
Compare
It wasn't actually my intention to make changes to the rtld Makefile, it was an accident since I was just copying over what rtld was doing to check for c18n, but might as well :). I broke it out into a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent changes in CTSRD-CHERI/llvm-project#731, we need to guard these libunwind defines behind aarch64 to avoid breaking other archs (like CHERI-RISC-V).