makesyscall.lua cleanups #2226
Merged
makesyscall.lua cleanups #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysc is local by virtue of being an iterator
Nothing uses them now so reduce diff to freebsd.
All we did was ignore them.
We don't need sysargmask for non-CHERI architectures.
Rename variable to match default value.
It is unused
Fixes: 3c6211e Add cheri_cidcap_alloc(2)
Comment aligning was inconsistent and required a ton of book-keeping. Replaced comment aligning with a simple, single tab out. Pull Request: freebsd/freebsd-src#1441 Signed-off-by: agge3 <sterspark@gmail.com> (cherry picked from commit e668866c82f487fe36c4e732e3ce18ae9c44260f)
An upcoming refactor appends do-not-merge comments to all headers centrally to do the same to reduce the final diff. Headers also start with a comment line (for /*) and end with a blank line. (cherry picked from commit 0d490c6a445a5e94e5d50b65aa96ab72eeafe15f)
Add blank like after comment to align with upcoming refactor for makesysent.lua. Fixes: 0d490c6a445a sysent: make header comments more consistent (cherry picked from commit 0f1d5bfb7297aca850a8c499a7b7fd0fd440cd50)
bsdjhb
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted cleanups in preparation for an upstream refactoring of this code. A mix of changes to converge the overall output and cleanups of local remnants.