Morello purecap kernel #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
commented
Jul 13, 2023
bsdjhb
force-pushed
the
morello_purecap_kernel
branch
2 times, most recently
from
0cec5d6
to
b0e82d9
Compare
... 2021 |
bsdjhb
force-pushed
the
morello_purecap_kernel
branch
from
b0e82d9
to
2a61be3
Compare
Oof, yeah, I had misparsed. The last dev run which used purecap Morello kernels was https://ctsrd-build.cl.cam.ac.uk/job/CheriBSD-pipeline/job/dev/93. |
bsdjhb
force-pushed
the
morello_purecap_kernel
branch
from
2a61be3
to
dbce711
Compare
When booting an image with a non-default kernel on a platform using loader rather than direct booting (e.g. Morello), expect needs to interrupt the loader and select the alternate kernel before booting, but we weren't checking we managed to do this, only that if we saw the loader countdown we were able to interrupt it. Thus add a check to fail if the boot gets to single user (mounting root) without having seen the loader prompt.
Upstream FreeBSD changed the autoboot countdown string in September of 2019 (merged to CheriBSD in late December 2022). The existing regex didn't match the new string, so test boots requesting a non-default kernel on Morello (e.g. the purecap kernel) have been booting the default (hybrid) kernel instead. This updates the regex to match on the new string as well as the old.
bsdjhb
force-pushed
the
morello_purecap_kernel
branch
from
dbce711
to
7a7e0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: We haven't been testing the Morello purecap kernel in CI since the end of December as the tests are booting the hybrid kernel instead.