This repository has been archived by the owner on May 2, 2019. It is now read-only.
Fix capsizefix base and length fixup when we fall back to using the section bounds #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection bounds When we are not able to find the size of a symbol, we conservatively use the section bounds. The bug causes the base to be set to the symbol address and the length to the section size, leading to capabilities that go outside the section bounds. The fix sets base and length to be equal to the section start and size and the capability offset is set to the symbol address. Fix minor bug in llvm-objdump -C reporting incorrect capability relocation permissions.
|
Please can you include a test case (e.g. a .S file that's run through llvm-mc and then capsizefix, then objdump'd to give the correct locations)? |
|
Ping? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are not able to find the size of a symbol, we conservatively use the section
bounds. The bug causes the base to be set to the symbol address and the length to
the section size, leading to capabilities that go outside the section bounds.
The fix sets base and length to be equal to the section start and size and the
capability offset is set to the symbol address.
Fix minor bug in llvm-objdump -C reporting incorrect capability relocation permissions.