CHERI-RISC-V As-User instructions and plumbing #193
+288
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwf
force-pushed
the
202111-riscv-cap-as-user
branch
2 times, most recently
from
46b0cb9 to
e4312c6
Compare
We need to assert PAGE_SC_TRAP if either PTE_CW or PTE_CD are clear, as otherise we can end up caching a TLB entry without SC_TRAP for a PTE that's merely got PTE_CW without PTE_CD turned on. This is similar to the existing logic around PTE_D.
For targets that composite their decode trees out of multiple files, properly track the dependency. This is a little gross in that it relies on the decodetree script to tell the build system what the build system already knows, in some sense, but it was the least invasive option that came to mind as the existing interface does not distinguish betweeen extra files and extra command line arguments to the decodetree script.
MMU_USER_IDX is not widely used in riscv, but looking at other architectures it appears that the intent of the symbol is to name the userspace mmu_idx.
- Restructure the code under the assumption that there will be HINT consumers
other than TCG_LOG_INSTR.
- Document the current and near-term allocations of the opcode space:
- Move the TCG_LOG_INSTR tests to match rs1 == x0, which is the only form that
we have emitted, but we were never ignoring rs1.
- Reserve `SLTI x0, x31, 0xNNN` forms for software's introspective use until
(and if) RISC-V upstream defines something for that use case.
nwf
force-pushed
the
202111-riscv-cap-as-user
branch
from
e4312c6 to
3e403f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the plumbing was done for Morello support already (huzzah).