Update cheri-compressed-cap to fix Morello HW divergences #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
fast-rep-check-and-morello-regression-fix
branch
4 times, most recently
from
bc8847e
to
c1d6033
Compare
arichardson
force-pushed
the
fast-rep-check-and-morello-regression-fix
branch
from
c1d6033
to
31b7d87
Compare
|
Updated (no longer includes fast rep check changes). Will commit once CI is happy. Fixes a RISC-V assertion for with tag-clearing enabled. |
arichardson
force-pushed
the
fast-rep-check-and-morello-regression-fix
branch
2 times, most recently
from
87e090d
to
7787f82
Compare
This fixes the regression introduced while updating cheri-compressed-cap to CTSRD-CHERI/cheri-compressed-cap@1a3898f and avoids asserting when attempting to use setbounds on untagged capabilities for RISC-V (which is possible with the new V9 semantics enabled): ``` .4byte 0x007a285b # csetboundsimmediate x16, x20, 7 .4byte 0x01082a5b # csetboundsimmediate x20, x16, 16 ``` with tag-clearing enabled. git subrepo pull target/cheri-common/cheri-compressed-cap subrepo: subdir: "target/cheri-common/cheri-compressed-cap" merged: "e459597bfe" upstream: origin: "https://github.com/CTSRD-CHERI/cheri-compressed-cap" branch: "master" commit: "e459597bfe" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "dbb99be"
Calling this with zero length is fine and works as intended.
arichardson
force-pushed
the
fast-rep-check-and-morello-regression-fix
branch
from
7787f82
to
64e0c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes both the Morello regression and using setbounds on untagged capabilities for RISC-V when tag-clearing is enabled.