[CHERI-RISC-V] Remove DDC interposition from CHERIv9 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
remove-ddc-interpos
branch
from
f111a4e
to
b6a0485
Compare
|
rebased and fixed a silly typo that caused the wrong unaligned exception type to be raised (store instead of load). Surprisingly this was caught by the MIPS tests |
arichardson
force-pushed
the
remove-ddc-interpos
branch
from
b6a0485
to
4d46035
Compare
Instead use a new CHERI_TRANSLATE_DDC_RELOCATION macro that is defined in each of the cheri-archspecific-early.h headers. This will make it easier to disable DDC relocation for RISC-V.
This can be used to compute the value of an integer pointer checked via DDC. The current behaviour in check_ddc() was incorrect for Morello as Morello can dynamically enable/disable DDC interposition and uses the base rather than the address of DDC for relocation.
This is needed to allow removal of DDC interposition from RISC-V and as nice side-effect it removes the confusing #ifdef TARGET_AARCH64.
This will become the default eventually but for now we need to keep it as an opt-in feature.
We were unconditionally adding the DDC address rather than using the cheri_ddc_relative_addr() helper.
We were unconditionally adding the DDC address rather than using the cheri_ddc_relative_addr() helper.
arichardson
force-pushed
the
remove-ddc-interpos
branch
from
4d46035
to
4ac5a42
Compare
bsdjhb
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with some hand-written TestRIG traces: CTSRD-CHERI/TestRIG-traces#1