Add Thumb instruction tracing for Arm32 #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
force-pushed
the
arm-tracing-thumb
branch
2 times, most recently
from
c14bb00
to
3e2424e
Compare
bsdjhb
reviewed
Jul 1, 2024
| @@ -14033,11 +14033,18 @@ void aarch64_sve_change_el(CPUARMState *env, int old_el, | |||
| #endif | |||
|
|
|||
| #ifdef CONFIG_TCG_LOG_INSTR | |||
| void HELPER(arm_log_instr)(CPUARMState *env, target_ulong pc, uint32_t opcode) | |||
There was a problem hiding this comment.
Why the switch from target_ulong to uint64_t? Is it to avoid having to call tcg_temp_free? I guess there isn't a tcg_constant_tl you could use instead of tcg_const_tl?
There was a problem hiding this comment.
The problem is that qemu-sysmte-aarch64 and qemu-system-arm both need to call this and for the former tl is 64-bit and the latter makes it 32. So the simplest solution was to just use 64 unconditionally.
bsdjhb
approved these changes
Jul 23, 2024
arichardson
force-pushed
the
arm-tracing-thumb
branch
from
3e2424e
to
a31ca0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.