gdb: Expose CHERI SCRs via the GDB stub #261
Open
+230
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdjhb
commented
Sep 3, 2024
| int index; | ||
| const char *name; | ||
| bool code; | ||
| } scrs[] = { |
There was a problem hiding this comment.
This duplicates scr_info in cheri_op_helper.c a bit. However, using all-lowercase names is more consistent with other registers exported via GDB.
jrtc27
reviewed
Sep 3, 2024
This should fix the use of CSR names in the GDB stub.
This matches the style for all other RISC-V registers including CSRs and avoids a weird collision with STDC which zlib defines as an alias of __STDC__.
This does not expose PCC and DDC in the new SCRs register group since those are already in the general purpose CHERI group.
bsdjhb
force-pushed
the
riscv_scr_gdb
branch
from
92a33ac
to
a164216
Compare
|
This also fixes CSRs exported by GDB to use their name instead of 'csrXXX' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not expose PCC and DDC in the new SCRs register group since those are already in the general purpose CHERI group.