[interpreter] Don't number non-lexicals in TDZ elision

Non-lexical bindings don't need to be numbered because they don't have a
TDZ. It is not incorrect to number them, but wasteful and may prevent
lexicals from being numbered and elidable.

Bug: v8:13723
Change-Id: Ife8de789622978b173951dd6d89231397af9dc53
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4552603
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#87810}

src/ast/scopes.cc

@@ -751,6 +751,10 @@ void DeclarationScope::DeclareThis(AstValueFactory* ast_value_factory) {
       THIS_VARIABLE,
       derived_constructor ? kNeedsInitialization : kCreatedInitialized,
       kNotAssigned);
+  // Derived constructors have hole checks when calling super. Mark the 'this'
+  // variable as having hole initialization forced so that TDZ elision analysis
+  // applies and numbers the variable.
+  if (derived_constructor) receiver_->ForceHoleInitialization();
   locals_.Add(receiver_);
 }
 

src/interpreter/bytecode-generator.cc

@@ -4031,7 +4031,7 @@ void BytecodeGenerator::BuildVariableAssignment(
       }
 
       if (mode != VariableMode::kConst || op == Token::INIT) {
-        if (op == Token::INIT) {
+        if (op == Token::INIT && variable->IsHoleInitializationForced()) {
           // After initializing a variable it won't be the hole anymore, so
           // elide subsequent checks.
           RememberHoleCheckInCurrentBlock(variable);
@@ -4072,7 +4072,7 @@ void BytecodeGenerator::BuildVariableAssignment(
       }
 
       if (mode != VariableMode::kConst || op == Token::INIT) {
-        if (op == Token::INIT) {
+        if (op == Token::INIT && variable->IsHoleInitializationForced()) {
           // After initializing a variable it won't be the hole anymore, so
           // elide subsequent checks.
           RememberHoleCheckInCurrentBlock(variable);