[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects #5258

jongmin-won · 2024-06-14T09:12:52Z

http://jira.cubrid.org/browse/CBRD-25352

Purpose
We will implement a feature to create a User Schema in Java Stored Procedure to ensure consistency with other objects such as tables, triggers, serial, servers, and synonyms.

Implementation
N/A

Remarks
AS-IS

Procedures and functions can be used by other users, independent of the owner.

CALL login ('test_user1', '') ON CLASS db_user;
CREATE FUNCTION function_hello() RETURN STRING AS LANGUAGE JAVA NAME 'SpCubrid.HelloCubrid() return java.lang.String';

CALL login ('dba', '') ON CLASS db_user;
SELECT function_hello() FROM db_root;

TO-BE

When a user other than the owner uses a procedure or function, they must specify the owner_name.

CALL login ('test_user1', '') ON CLASS db_user;
CREATE FUNCTION function_hello() RETURN STRING AS LANGUAGE JAVA NAME 'SpCubrid.HelloCubrid() return java.lang.String';

CALL login ('dba', '') ON CLASS db_user;
SELECT test_user1.function_hello() FROM db_root;

… feature/plcsql-p1n branch to add a user schema to a stored procedure.

…ditionally, class methods are system tables and do not require user_schema. ex) 'add_user', 'drop_user', 'find_user'

…Additionally, Resolves an error where the CALL PROCEDURE/FUNCTION statement does not work correctly.

…ocedure object, 2) select hello(); Modified so that [user_name.]hello is displayed when an error message occurs because the corresponding sp cannot be found during execution.

…ion user when executing a CREATE OR REPLACE PROCEDURE/FUNCTION, 2) Add user_schema to SP when performing a schema unload

…ames() to simplify it.

…d within an if-else-statement when the CALL statement is executed. 2) Added a part to remove the owner and user_schema when the unloaddb utility is executed as a general user, provided that the owner and user_schema are the same.

… 발생하도록 수정 ex) u1 사용자가 create function u2.hello 수행할 경우

…stem method 와 user method (Function& Stored_procedure) 구분을 grammar.y에서 확인하도록 수정

…st에 세션 변수가 있는 경우, csql_grammar.y에서는 세션 변수에 클래스, 객체 또는 상수 중 어떤 값이 포함되어 있는지 알 수 없습니다. 따라서, pt_bind_names()에서 java_stored_procedure가 아니고 on_call_target 값이 있으면 method로 간주하여 [user_schema]를 제거합니다.

…y value 로 잘 못 수정되는 부분 수정, 2) PT_FUNCTION 노드를 수행시 generic_name 값을 항상 downcase 하도록 수정

…x) select HELLO(); -> Query stmt: select HELLO() from dual dual

…evelop과 같이 data_type 토큰을 sp_param_type 토큰으로 변경했습니다.

src/parser/csql_grammar.y

src/object/schema_system_catalog_install.cpp

…o pl/csql execution.

src/parser/name_resolution.c

src/parser/semantic_check.c

src/parser/parse_tree.h

src/parser/name_resolution.c

src/sp/sp_catalog.cpp

…value in System pl/csql has been modified as follows. [public].[dbms_output].[System_pl_csql_name] 3) We have decided to integrate the unload_schema code modification into another issue (separated for unload integration testing).

…ma specified in the manual is 222 bytes, but the actual error message is displayed as 223 bytes. Therefore, I have modified the error message.

src/parser/semantic_check.c

src/sp/jsp_cl.cpp

…ique_name in the change_sp_owner method.

…trdup to generate the sp_info.unique_name value, but failed to release the memory. To rectify this, we have added code to free the memory.

…on character ('\0') when performing downcase.

…DBC, the SQL syntax included in the error message no longer displays [user_schema]. (#1967) http://jira.cubrid.org/browse/CBRD-25416 In a past PR (CUBRID/cubrid#5258), functionality was added to allow the use of [user_schema] in SPs, and the TC was modified accordingly. However, in PR (CUBRID/cubrid#5615), the logic was updated so that [user_schema] is removed from SPs in JDBC error messages.

Merge the code from the main development branch (CBRD-25352) into the…

76f3145

… feature/plcsql-p1n branch to add a user schema to a stored procedure.

jongmin-won self-assigned this Jun 14, 2024

jongmin-won added 8 commits June 18, 2024 09:04

Modify to execute the CALL PROCEDURE/FUNCTION statement correctly. Ad…

1ce9ff5

…ditionally, class methods are system tables and do not require user_schema. ex) 'add_user', 'drop_user', 'find_user'

Modify to execute the SELECT PROCEDURE/FUNCTION statement correctly. …

fab738a

…Additionally, Resolves an error where the CALL PROCEDURE/FUNCTION statement does not work correctly.

Merge commit 'f101fbc9c' into feature/plcsql-CBRD-25352

b2ade1d

1) Add unique_name to sp_info object to find pl/casl system stored pr…

95a96e0

…ocedure object, 2) select hello(); Modified so that [user_name.]hello is displayed when an error message occurs because the corresponding sp cannot be found during execution.

1) Resolving the issue where the OWNER is changed to the current sess…

1aeb682

…ion user when executing a CREATE OR REPLACE PROCEDURE/FUNCTION, 2) Add user_schema to SP when performing a schema unload

Modify the if-statement in the case PT_METHOD_CALL: part of pt_bind_n…

6f190ca

…ames() to simplify it.

Merge branch 'goodone' into feature/plcsql-CBRD-25352

f90eab9

jongmin-won force-pushed the feature/plcsql-CBRD-25352 branch from 8140d1b to 4fabc96 Compare July 3, 2024 04:56

jongmin-won added 2 commits July 4, 2024 17:45

Merge commit 'fe9cd5192' into feature/plcsql-CBRD-25352

1a797f1

dba 와 dba 그룹 이외 사용자가 다른 사용자의 CREATE PROCEDURE/FUNCTION 구문을 사용할 경우 에러가…

c658a6c

… 발생하도록 수정 ex) u1 사용자가 create function u2.hello 수행할 경우

jongmin-won requested review from hgryoo, hyunikn and ctshim July 5, 2024 02:05

jongmin-won marked this pull request as ready for review July 5, 2024 02:10

jongmin-won requested a review from beyondykk9 as a code owner July 5, 2024 02:10

jongmin-won added 8 commits July 9, 2024 22:10

1) test_sql 에서 error가 발생하는 case 수정(trigger_action, query_spec), 2) sy…

e2d51a1

…stem method 와 user method (Function& Stored_procedure) 구분을 grammar.y에서 확인하도록 수정

1) ALTER PROCEDURE/FUNCTION 구문에서 OWNER TO 없이 수행시 unique_name의 값이 empt…

170b14c

…y value 로 잘 못 수정되는 부분 수정, 2) PT_FUNCTION 노드를 수행시 generic_name 값을 항상 downcase 하도록 수정

[Rollback] PT_FUNCTION 노드를 수행시 generic_name 값은 사용자가 입력한 그대로 출력하게 수정 e…

df41f70

…x) select HELLO(); -> Query stmt: select HELLO() from dual dual

name_resolution 파일에 오타 수정

aca5193

name_resolution 파일에 누락된 if-statement 추가

f869886

sp_param_def 토큰 내부의 sp_param_type 토큰 위치에 data_type 토큰이 잘못 사용되었기 때문에 d…

c0fa0ff

…evelop과 같이 data_type 토큰을 sp_param_type 토큰으로 변경했습니다.

Merge commit 'c18553564' into feature/plcsql-CBRD-25352

f8ab9a0

jongmin-won mentioned this pull request Jul 15, 2024

[CBRD-25352] Add a user schema to your stored procedures for consistency with other objects CUBRID/cubrid-testcases#1768

Merged

Merge commit 'ca9beeff5' into feature/plcsql-CBRD-25352

61fb31e

ctshim reviewed Jul 15, 2024

View reviewed changes

src/parser/csql_grammar.y Outdated Show resolved Hide resolved

Fixed an error where the next value of the PT_DOT node is missing

b9cae15

hgryoo reviewed Jul 19, 2024

View reviewed changes

src/object/schema_system_catalog_install.cpp Outdated Show resolved Hide resolved

hgryoo reviewed Jul 19, 2024

View reviewed changes

src/object/schema_system_catalog_install.cpp Outdated Show resolved Hide resolved

jongmin-won added 2 commits July 19, 2024 17:38

Add dbms_output user_schema to CALL enable and CALL disalbe related t…

df4f051

…o pl/csql execution.

I modified it by referring to the code review.

5694430