Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #14

Closed
6 tasks done
kadishmal opened this issue Jan 28, 2015 · 0 comments
Closed
6 tasks done

Code refactoring #14

kadishmal opened this issue Jan 28, 2015 · 0 comments
Assignees
@kadishmal
Labels
enhancement
Milestone
3.0.0

Comments

@kadishmal
Copy link
Contributor

kadishmal commented Jan 28, 2015 •
edited
Loading

  • In _closeQuery instead of looping through _queriesPacketList to find the queryHandle, maintain an object whose keys are the queryHandle.
  • Extract constants and other useless variables from the connection object.
  • Set noDelay(true) only once right after the socket gets created.
  • Reduce the use of self where this can be used directly. 365f867
  • Indent using spaces instead of tabs.
  • Support promises.
@kadishmal kadishmal modified the milestones: 2.2.1, 2.2.2 Jan 30, 2015
kadishmal added a commit that referenced this issue Feb 1, 2015
@kadishmal
Ref #14: Reduce the use of self where this can be used directly.
365f867
@kadishmal kadishmal modified the milestones: 2.2.2, 2.3.0 Mar 11, 2015
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
60ddd9e
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
7965ae9
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
525b2dc
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
b29d8a9
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
941122e
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Ref #14: Indent using spaces instead of tabs.
4405f1d
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#49 Implement Protocol v6 of CUBRID.
99dde5f 
New Features

#49 Implement Protocol v6 of CUBRID.
#13 Add support for alternative hosts to support client side HA.
#12 #11 Provide a configurable logging function.
#18 Added ENUM data type support via the old protocol.
#14 Support promises.
Refactoring

#48 Update README.
#14 Indent using spaces instead of tabs.
#14 Reduce the use of self where this can be used directly.
#14 Extract constants and other useless variables from the connection
object.
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Test on multiple Node versions.
85656d0
@kadishmal kadishmal mentioned this issue Oct 5, 2016
Merged
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Node >=4.5 uses Buffer.from() to create a new Buffer object.
084bc55
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Push code coverage report to coveralls.io.
750f0bf 
Applicable to Travis CI builds only.
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Show Docker container logs.
60c4b5d
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 CUBRID 9.2.26.0004 demodb doesn't start on Travis.
b381672
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Reverse the Node versions.
343d8c0
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Add test for getSchema().
1b89be3
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Fix test: CUBRID 9+ has a different response for `CCI_SCH_IMPORTE…
f10eec8 
…D_KEYS`.
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14: Update the README.
d68254e
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
#14 Fix the failing test.
72f8d38
kadishmal added a commit that referenced this issue Oct 5, 2016
@kadishmal
Merge pull request #50 from CUBRID/14
4643ab1 
Closes #49, #11, #12, #13, #14, #48 Implement Protocol v6 of CUBRID.
@kadishmal kadishmal added this to the 3.0.0 milestone Oct 5, 2016
@kadishmal kadishmal self-assigned this Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kadishmal kadishmal

Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@kadishmal