Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When closing a query, if connection is closed, consider the request was successful #15

Closed
kadishmal opened this issue Jan 30, 2015 · 0 comments
Assignees
Labels
Milestone

Comments

@kadishmal
Copy link
Contributor

According to CUBRID CCI native driver implementation function qe_send_close_handle_msg(), we can consider the connection closed operation as a successful request.

This is true because internally CUBRID Broker manages a pool of CAS (CUBRID Application Server) processes. When a client connects, the Broker assigns/connect it to one of the CAS. Then the client sends some query requests to this CAS. After the client receives a response, it may decide to do some other application logic before it closes the query handle. Once the client is done with the response, it may try to close the query handle.

In between these receive response and close query, CUBRID Broker may reassign the CAS to another client. Notice the client-Broker connection is not broken. When the actual close query request arrives to the Broker, it finds out that the CAS referred by the client is reassigned, it sends CONNECTION RESET to the client. node-cubrid should listen it and consider such event as if the close query request was successful.

Need to check if this is the same for close connection and other similar requests.

@kadishmal kadishmal added this to the 2.2.1 milestone Jan 30, 2015
@kadishmal kadishmal self-assigned this Jan 30, 2015
@kadishmal kadishmal added bug and removed enhancement labels Feb 1, 2015
kadishmal added a commit that referenced this issue Feb 24, 2015
kadishmal added a commit that referenced this issue Feb 24, 2015
Fix #15: When closing a query, if connection is reset, consider the request was successful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant