Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename languages as data. #147

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Rename languages as data. #147

merged 3 commits into from
Apr 18, 2020

Conversation

kylebgorman
Copy link
Collaborator

@kylebgorman kylebgorman commented Apr 18, 2020 •
edited
Loading

  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

@kylebgorman kylebgorman requested a review from lfashby April 18, 2020 12:57
lfashby
lfashby approved these changes Apr 18, 2020
View reviewed changes
Copy link
Collaborator

@lfashby lfashby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't think of how these changes would lead to any errors in the big scrape scripts.

@kylebgorman
Copy link
Collaborator Author

Thanks, that's what I was worried about but couldn't think of anything either.

@kylebgorman kylebgorman merged commit 84e9ddd into master Apr 18, 2020
@kylebgorman kylebgorman deleted the rename branch June 12, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfashby lfashby lfashby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylebgorman @lfashby