Vietnamese extraction function #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ikipron accepted keys
…o_skip_spaces_pron flag for tibetan and persian
kylebgorman
approved these changes
Jun 10, 2020
|
Gentle ping: should I merge this? |
|
I'll merge it in. I reached out to Jackson separately regarding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnreleasedinCHANGELOG.mdto reflect the changes in code or data.This PR includes an extraction function for Vietnamese, data from scraping Vietnamese with this new extraction function, and the removal of a duplicate of the Manchu entry in
languages.json(I'll have to look into how that got there).This Vietnamese extraction function is tentative and works around the problem raised in #149 by redefining and utilizing
_DIALECT_XPATH_SELECTOR_TEMPLATEwithin the extraction function itself. Whatever solution we come up with to handle #149 will likely require reworking this extraction function, but I've submitted it as is because it makes clear some of the problems we will face in solving #149 - such as that Vietnamese dialects require a different dialect selector than is needed for other languages and that extraction functions which do not call_yield_phnneed some way of being exposed to the dialect specifications.Resolves #133