Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial data side reorganization #394

Merged
merged 10 commits into from
Mar 25, 2021
Merged

Partial data side reorganization #394

merged 10 commits into from
Mar 25, 2021

Conversation

lfashby
Copy link
Collaborator

@lfashby lfashby commented Mar 25, 2021

  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

This PR contains a partial reorganization of wikipron/data according to the proposal in #360. I moved all of the scraping type scripts into a new data/scrape directory, reworked some paths given those changes, added a temporary data README that we can fill out once src is fully removed, and fixed a few oversights in a couple scraping scripts.

@lfashby lfashby requested a review from kylebgorman March 25, 2021 17:15
Copy link
Collaborator

@kylebgorman kylebgorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, not seeing any problems here.

data/README.md Outdated Show resolved Hide resolved
@lfashby lfashby merged commit 44e9e17 into CUNY-CL:master Mar 25, 2021
@lfashby lfashby deleted the org branch March 25, 2021 17:50
@ajmalanoski ajmalanoski mentioned this pull request Mar 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants