Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiny typo in main README #407

Merged
merged 28 commits into from
Apr 25, 2021
Merged

Fix tiny typo in main README #407

merged 28 commits into from
Apr 25, 2021

Conversation

ajmalanoski
Copy link
Collaborator

@ajmalanoski ajmalanoski commented Apr 25, 2021 •
edited
Loading

  • Updated Unreleased in CHANGELOG.md to reflect the changes in code or data.

@ajmalanoski
Adds subdirectories 'lib' and 'phones' to 'data/phones'. Moves '.phon…
36af387 
…es' files into 'data/phones/phones'. Moves relevant scripts from 'data/src' into 'data/phones/lib'. Updates paths in 'data/scrape/lib/codes.py'
@ajmalanoski
Updates 'data/phones/HOWTO.md' to reflect new locations of files
6f673f9
@ajmalanoski
Fixes file path in 'data/phones/HOWTO.md'
528cb1e
@ajmalanoski
Updates outdated components of 'data/phones/HOWTO.md'
6f8ea4c
@ajmalanoski
Updates path to phones in 'tests/test_data/test_summary.py'
2d98838
@ajmalanoski
Updates changelog
afdb768
@ajmalanoski
Merge branch 'master' into reorganize
a6b079c
@ajmalanoski
Renames 'data/cg' to 'data/covering_grammar'
ba0839a
@ajmalanoski
Renames covering grammar files to include script info and and transcr…
8f34b19 
…iption type (broad/narrow)
@ajmalanoski
Moves covering grammar/error analysis scripts to 'data/covering_gramm…
e9ab803 
…ar/lib'
@ajmalanoski
Adds placeholder README for 'data/covering_grammar/'
353d8f8
@ajmalanoski
Adds script to make input files for error analysis
c33739c
@ajmalanoski
Removes superfluous comments from 'data/covering_grammar/lib/make_tes…
abd10d0 
…t_file.py'
@ajmalanoski
Updates changelog
d52822a
@ajmalanoski
Merge branch 'master' of https://github.com/kylebgorman/wikipron into…
f7eefef 
… reorganize
@ajmalanoski
Makes (most of the) suggested edits to data/covering_grammar/lib/make…
d0b26ed 
…_test_file.py
@ajmalanoski
Adds logging config to data/covering_grammar/lib/make_test_file.py. M…
6c164bc 
…akes minor stylistic changes to the same file
@ajmalanoski
Minor style fix
0176fe7
@ajmalanoski
Merge branch 'master' of https://github.com/kylebgorman/wikipron
4505a49
@ajmalanoski
Adds French covering grammar. Reorganizes French phonelist.
de2afe5
@ajmalanoski
Updates changelog
5b47606
@ajmalanoski
Fix extra line in French phonelist
b8438dd
@ajmalanoski
Add end line to French covering grammar
a4618ce
@ajmalanoski
Add final lines
2037b1c
@ajmalanoski
Pull upstream
3ee9743
@ajmalanoski
Fix typo in README.md
0fde458
@ajmalanoski
Fix merge conflict
ddc8aba
@ajmalanoski
Update changelog
f423766
kylebgorman
kylebgorman approved these changes Apr 25, 2021
View reviewed changes
Copy link
Collaborator

@kylebgorman kylebgorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I'll submit this, thanks.

@kylebgorman kylebgorman merged commit 542a159 into CUNY-CL:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebgorman kylebgorman kylebgorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajmalanoski @kylebgorman