-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.1.0 accepts undefined properties under "affected" #259
Labels
Milestone
Comments
jayjacobs
added
section:affected_product
Schema location is affected or product
bug
Something isn't working
labels
Nov 22, 2024
ccoffin
added a commit
to ccoffin/cve-schema
that referenced
this issue
Dec 27, 2024
Add additionalProperties equal to false for the product object in the base schema. This resolves Issue CVEProject#259.
ccoffin
added a commit
to ccoffin/cve-schema
that referenced
this issue
Dec 27, 2024
Add additionalProperties equal to false for the product object in the bundled schema. This resolves Issue CVEProject#259.
ccoffin
added a commit
to ccoffin/cve-schema
that referenced
this issue
Dec 27, 2024
Add additionalProperties equal to false for the product object in the bundled schema. This resolves Issue CVEProject#259.
ccoffin
added a commit
to ccoffin/cve-schema
that referenced
this issue
Dec 27, 2024
Add additionalProperties equal to false for the product object in the bundled schema. This resolves Issue CVEProject#259.
ccoffin
added a commit
to ccoffin/cve-schema
that referenced
this issue
Dec 27, 2024
Add additionalProperties equal to false for the product object in the bundled schema. This resolves Issue CVEProject#259.
The above commits fix this issue by adding an additionalProperties false for the product object. This may result in some current CVE Records not validating if they have unexpected properties within affected/product. I went ahead and added additionalProperties to the bundled schemas as well since it is an easy addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
At the 2023-12-14 TWG meeting, the discussion suggested that, during testing of the 5.1.0 schema, any CVE Record that validated even though the record format was not "intended" would be considered a "loophole."
As far as I know, it was not intended that arbitrary properties be allowed under "affected" in a container, but records with these do validate.
minimal/plausible test case (the CNA uses the arbitrary property version even though it is a misspelling of the intended property versions)
possible solution:
Name of the organization
in the schema."additionalProperties":false,
issues on the current CVE List:
The text was updated successfully, but these errors were encountered: