-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update schema docs for CPE #389
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Art Manion <zmanion@protonmail.com>
Signed-off-by: Art Manion <zmanion@protonmail.com>
This looks like a small change but does this become schema 5.1.1? |
Good question, I've staged a v.5.1.0 archive copy (matching the content of the v.5.0 directory). We've got some cruft/duplication building up (like a collection of node_modules and a 2016 .xlsx) but I didn't go through everything carefully. It might make sense to keep the current node_modules but maybe not keep the archives of them? Looks like we name/rename the archived schema files with their version, e.g., CVE_JSON_5.0_schema.json, but the currenet schema is named CVE_Record_Format.json. Should we record the schema version in some way? If not by file name, then add a version key/value?
Or if filenames, use symlinks?
|
I think a version key in the schema makes a lot of sense. |
Signed-off-by: Art Manion <zmanion@protonmail.com>
Signed-off-by: Art Manion <zmanion@protonmail.com>
Discussed briefly at 2025-03-06 QWG meeting, one option is to not accept this PR and @ccoffin will run some other documentation update magic. Note that the documentation update tools in this repo need some minor edits if we intend to continue using them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit (ff1dd11) should not be accepted, .oneOf[].properties.dataVersion
already exists.
Proposed resolution for #388.