Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/README.md can lead to world-readable API key #781

Closed
ElectricNroff opened this issue Jul 19, 2022 · 1 comment · Fixed by #797
Closed

docker/README.md can lead to world-readable API key #781

ElectricNroff opened this issue Jul 19, 2022 · 1 comment · Fixed by #797
Assignees

Comments

@ElectricNroff
Copy link
Contributor

This might be considered a #621 regression because the current version removes code that had been added in 21320be

https://github.com/CVEProject/cve-services/blob/7f683512e5bcd07f8ce48d41d06ea533c90dd265/docker/README.md
says

Create a curl config file in $HOME/.curl-cve-config similar to the following

but does not discuss whether file permissions should be set in any specific way. Many popular systems have a default configuration in which files in a user's home directory can be read by some or all other users. There is a risk that an API key could be stolen if a threat actor has unprivileged local access to a host that is used for command-line CVE Services API access.

By contrast, https://github.com/CVEProject/cve-services/blob/6e4f176ff305ceb0e7747d2e5991a580267de73f/docker/README.md had set the .curl-cve-config file permissions to 600 before writing the API key into the file.

@slubar
Copy link
Contributor

slubar commented Jul 25, 2022

Add instructions to set the .curl-cve-config file permissions to 600 before writing the API key into the file.

@brettp brettp self-assigned this Jul 27, 2022
slubar added a commit that referenced this issue Jul 28, 2022
#781 Update Docker readme to include instructions to securely create curl config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants