Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #1011 Refactored null checks for owningCnaShortName and assignerShortName #1026

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Resolves #1011 Refactored null checks for owningCnaShortName and assignerShortName #1026

merged 1 commit into from
Feb 14, 2023

Conversation

jdaigneau5
Copy link
Collaborator

@jdaigneau5 jdaigneau5 commented Feb 14, 2023 •
edited
Loading

Closes Issue #1011

Summary

Updated the null checks for owningCnaShortName and assignerShortName in submitCna and newRejectedCve functions.

Important Changes

cve.controller.js

  • Removed optional chaining for owningCna

cve.js
-Removed or condition setting assignerShortName to null

@jdaigneau5 jdaigneau5 requested a review from slubar February 14, 2023 15:00
@slubar slubar linked an issue Feb 14, 2023 that may be closed by this pull request
"owningCnaShortName || null" leads to incorrect JSON validation error #1011
Closed
@slubar slubar merged commit a2c8d21 into dev Feb 14, 2023
@slubar slubar deleted the jd-1011 branch February 14, 2023 16:31
@ekmixon ekmixon mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slubar slubar slubar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"owningCnaShortName || null" leads to incorrect JSON validation error
2 participants
@jdaigneau5 @slubar