Resolves #809 Prevents org admins from removing their admin role #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #809
Summary
Added logic to prevent org admin users from self demoting and removing their own admin role.
Important Changes
error.js
notAllowedToSelfDemote
with message 'Please have another admin user from your organization change your role.'org.controller.js
updateUser
function, changedforEach
loop tofor...in
so returning errors breaks out of functionnotAllowedToSelfDemote
when user tries to remove their own admin roleTesting
Steps to manually test updated functionality, if possible