Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves 1058, 1060 Implements ADP role and AdpOnly middleware #1071

Merged
merged 12 commits into from
May 17, 2023
Merged

Resolves 1058, 1060 Implements ADP role and AdpOnly middleware #1071

merged 12 commits into from
May 17, 2023

Conversation

jdaigneau5
Copy link
Collaborator

@jdaigneau5 jdaigneau5 commented May 16, 2023 •
edited
Loading

Closes Issues 1058, 1060

Summary

Integrated ADP role and middleware. Created unit tests to ensure middleware is properly providing and restricting access.

Important Changes

middleware.js

  • Added adpOnly middleware

onlyAdpsTest.js

  • Added unit tests for adpOnly middleware

Notes

  • This PR includes other ADP code pulled from Matt, which will be reviewed and have tests added

github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2023
View reviewed changes
src/controller/cve.controller/index.js
}
}
*/
mw.validateUser,

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
@jdaigneau5 jdaigneau5 merged commit d1ad208 into dev May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athu-tran athu-tran athu-tran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdaigneau5 @athu-tran