Resolves #1013 Updated onlyOrgWithRole middleware to onlyOrgWithPartnerRole #1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #1013
Summary
The
onlyOrgsWithRole
middleware function allowed theBULK_DOWNLOAD
organization to access non GET endpoints. This goes against the principle of least privilege, so the middleware was updated to allow only orgs with partner roles, like Cna, Adp, to be granted access.Important Changes
middleware.js
onlyOrgsWithRole
function to check for orgs with non-partner rolesTesting
Steps to manually test updated functionality, if possible
npm run test:unit-tests
BULK_DOWNLOAD
role can only access the GET /cve endpoint