Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #1163 Added datePublic validator with 24 hour grace period #1240

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

jdaigneau5
Copy link
Collaborator

Closes Issue #1163

Summary

Added a datePublic validator middleware that prevents records from being created or updated to have a datePublic more than 24 hours from the current time.

Important Changes

cve.middleware.js

  • Added 24 hour grace period logic to existing (but not implemented) datePublicValidator.

Testing

Added unit test to test 24 hour grace period.
Run npm run test:unit-tests

@jdaigneau5 jdaigneau5 requested a review from david-rocca June 28, 2024 18:07
Copy link
Collaborator

@david-rocca david-rocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-rocca david-rocca merged commit 067c940 into dev Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants