Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull out constants into a function to prevent accidental overriding #934

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Pull out constants into a function to prevent accidental overriding #934

merged 2 commits into from
Dec 5, 2022

Conversation

brettp
Copy link
Collaborator

@brettp brettp commented Nov 30, 2022

This is the first pass at addressing #920 by making sure constant values aren't accidentally overridden.

@brettp brettp requested review from slubar and jdaigneau5 November 30, 2022 20:19
slubar
slubar approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@slubar slubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to DEV for further testing

@slubar slubar merged commit 158a9ea into dev Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slubar slubar slubar approved these changes

@jdaigneau5 jdaigneau5 Awaiting requested review from jdaigneau5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettp @slubar