Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #894 Cve database updates must succeed before Cve-Id database updates #937

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

jdaigneau5
Copy link
Collaborator

Closes #894

Summary

Changed the order of database calls when creating or updating Cve records, so updating the Cve collection must succeed before updating the Cve-id collection. This prevents Cve records from being out of sync with their corresponding Cve-id.

Important Changes

cve.controller.js

  • Swapped the database update order in submitCve(), updateCna(), and rejectCve()

@jdaigneau5 jdaigneau5 requested a review from slubar December 1, 2022 17:31
@slubar slubar merged commit 7f7a295 into dev Dec 1, 2022
@slubar slubar deleted the jd-894 branch December 1, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write to Cve-Id collection only after successfully writing to Cve collection
2 participants