-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal Layout #51
Conversation
Conflicts: client/blog.html client/js/blogArchives.js
I'm sorry. I fixed it.
Since there's not really an 'Archive' anymore
The code looks good as far as I can tell but the page doesn't finish loading and becomes unresponsive for me so I can't check out anything you're doing in the browser. The issue is probably on my end. |
@D30XY I'm sorry to hear that it doesn't load for you. If you can figure it out, I'd be happy to have your help. |
Ok, problem solved. However, the scroll animation still isn't working |
Well, I haven't identified the culprit but the animation works fine in firefox (broken in Chrome and Safari). @J3RN What would you like to knock out next? |
I guess this is what I get for only testing against Firefox 😦 Right now I'm working on the parallax scrolling (I'm just writing it myself - it's trivial enough to not require a plugin). That means the only thing left is optimizing the sections to be forever-long. It's pretty open to interpretation, but by all mean - go for it! |
Oh! And don't forget to pull first, there's lots of recent changes! |
Wait where are you putting the parallax? Is it going in |
Kittens are scary up close
I just finished the parallaxing. Unfortunately, I had to rollback your header shrinkage. It was supposed to look like that, as the image parallaxes in the background. Eventually we'll fix those headers up to be centered and pretty and whatnot. Enjoy the parallaxing, though! 😄 |
Nice, looks good! |
Alright guys -- One of the things I've been working on is getting the current section to remain centered in the viewport when resizing the browser window (previously the sections would expand, and the viewport did not follow the current section offset). I spun up two super hacky solutions to this problem, the latter of which I think looks much more 'natural' and is currently in use if you want to check it out. If you want to check out the first one, open the previous commit with Alright, so here's how it works:
This all happens seamlessly so that it looks like the section stays in place and resizes with the window, like one would expect. After the resize is finished, the user is able to continue on browsing normally. |
Also, I created a responsive grid with breakpoints for the nav bar so that it resizes nicely. Only problem is that it breaks when the admin link is inserted. The problem is that each link container spans a column and when the admin link is added, there is one too many columns for the parent container. Since we are rethinking our login design (#52), I figure we can tack this issue onto it. |
@D30XY Nice work! Actually, we do have a grid system in place, which is Bourbon Neat. However, if it's working, I'd say don't fix it - at least for now. |
Sorry, I didn't phrase that properly. I did use the bourbon neat framework. I just gave the nav bar it's own row and split it up accordingly. |
OK, awesome! Thanks for clearing that up!
|
…ontal Conflicts: client/blog.html client/js/scroll.js
Alright, to get this presentation-ready, what I want is to get the admin section working again. Other things can be done post-merge. |
Cool, let's do it. Can you explain what you mean by getting the admin section working again? Do you mean the admin link or is there something wrong with the admin screen? |
@D30XY I was referring to the "Date is required" thing when created blog posts. You mentioned it a little while back. |
Oh, right. Yeah, the date chooser only shows up in chrome and I'm not entirely sure yet if there's much we can do about it. However, I have set it to insert today's date by default if not specified (or there is no date picker available) so the date field is no longer required. This will at least allow the admin to add new posts in other browsers. |
I wonder if we should just ditch the date field altogether and just have it insert today's date upon creation because why would you compose a blog post and assign a different date to it anyway? |
This is the approach that I’m leaning towards.
|
It is done! |
The date field is also omitted for the events collection because it has the same name in the schema. Have we made a decision about what we are going to do with this section? |
@afuhrtrumpet I think we're ready to merge this. |
The new horizontal layout
TODO: