LocalProcess class #206
Draft
LocalProcess class #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2024 09:42
- Define ExecutionHandler class, set SchedulerJob as a subclass - Define LocalProcess subclass of ExecutionHandler
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## scheduler_class #206 +/- ##
===================================================
+ Coverage 92.18% 92.78% +0.59%
===================================================
Files 40 44 +4
Lines 3623 3813 +190
===================================================
+ Hits 3340 3538 +198
+ Misses 283 275 -8
|
added 10 commits
December 23, 2024 14:05
…ionHandler instance - Update ROMSComponent.run() logic to create, start, and return a LocalProcess instance on a non-scheduler machine - Move 'updates' method definition from SchedulerJob into ExecutionHandler base class - Temporarily comment out ROMS output parsing in ROMSComponent.run()
…l set in 'run()') to prevent premature call to 'post_run()'
- Make ExecutionHandler.updates terminate when status changes from RUNNING - Add a 'confirm_indefinite' parameter to updates when seconds==0 to skip y/n confirmation if False - Add / update unit tests - Update integration tests to print updates
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
added 2 commits
December 24, 2024 14:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchedulerJobfor local execution (LocalProcess?) #203docs/releases.rstapi.rstThis PR is chained off of #205 (#175) and creates a base class
ExecutionHandlerof which bothSchedulerJobandLocalProcess(a newly defined class) are subclasses. This allows consistent behaviour whether or not the user is running on a scheduler-managed system: an object is returned byCase.run()that can be used to track the state of the run, even if that run is happening in the background locally.scheduler_classbranch. Please first merge #205 and update the base tomainbefore changing the status of this PR from draft.