Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize function blows up on unicode characters #421

Closed
andrewkrug opened this issue Sep 14, 2017 · 3 comments
Closed

sanitize function blows up on unicode characters #421

andrewkrug opened this issue Sep 14, 2017 · 3 comments
Assignees
Milestone

Comments

@andrewkrug
Copy link
Contributor

'ascii' codec can't encode characters in position 929-931: ordinal not in range(128)

Gets thrown by this function:

https://github.com/OpenIDC/pyoidc/blob/master/src/oic/utils/sanitize.py#L38

@decentral1se
Copy link
Contributor

PRs gladly accepted! Especially anyone will to brave the depths of encoding handling ... a dark and dangerous place.

@andrewkrug
Copy link
Contributor Author

This sanitize function primarily exists for stripping sensitive logs. I see no reason why it should raise and stop login flow if it fails.

@decentral1se
Copy link
Contributor

Yes, youre right. Its called in many places right? Perhaps it can be wrapped in a decorator and exceptions can be pased and fixed as seen (but without blocking flows). Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants