Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extra_claims #443

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Add support for extra_claims #443

merged 2 commits into from
Dec 1, 2017

Conversation

tpazderka
Copy link
Collaborator

@tpazderka tpazderka commented Dec 1, 2017 •
edited
Loading

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.

@tpazderka tpazderka force-pushed the support_extra_claims branch from 2094302 to ac87e67 Compare December 1, 2017 10:37
@coveralls
Copy link

coveralls commented Dec 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 60.169% when pulling ac87e67 on support_extra_claims into 81e5791 on master.

schlenk
schlenk reviewed Dec 1, 2017
View reviewed changes
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be nice to have some test coverage really requesting one of those extra claims, to make sure it does not blow up later (e.g. in message serialization of the ID Token / UserInfo because the extra claim fields are not listed in the default OpenIDSchema for example).

If that is the case, the code should warn if the schema isn't also configured.

@tpazderka
Copy link
Collaborator Author

OK, I will add a test for requesting and extra claim.

@tpazderka
Copy link
Collaborator Author

I have added tests for userinfo_endpoint and extra_claims. No further configuration is necessary.

@coveralls
Copy link

coveralls commented Dec 1, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 60.189% when pulling 4ea5b11 on support_extra_claims into 81e5791 on master.

schlenk
schlenk approved these changes Dec 1, 2017
View reviewed changes
Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpazderka tpazderka merged commit c0f8292 into master Dec 1, 2017
@tpazderka tpazderka deleted the support_extra_claims branch December 1, 2017 15:04
andrewkrug pushed a commit to mozilla-iam/pyoidc that referenced this pull request Jun 6, 2019
@tpazderka @andrewkrug
Add support for extra_claims (CZ-NIC#443)
62a59e9 
* Add support for extra_claims
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlenk schlenk schlenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpazderka @coveralls @schlenk