Bugfix/working simple examples #542
Conversation
|
Since the examples are SO broken, I am not against merging this with some stuff unfinished. Can you please update this to a current master as some stuff got already fixed? |
|
Sure, I'll add some TODOs to the parts I don't quite understand and rebase Thanks! |
claweyenuk
force-pushed
the
bugfix/working-simple-examples
branch
from
5eeeee4 to
52bbe89
Compare
|
I think this one is good (enough) to go now |
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 62 62
Lines 11247 11247
Branches 1981 1981
=======================================
Hits 6707 6707
Misses 3982 3982
Partials 558 558Continue to review full report at Codecov.
|
|
The example README calls out #543 which I did not know how to work around |
| @@ -1,4 +1,3 @@ | |||
| oic==0.7.6 | |||
| pyjwkest==1.0.1 | |||
There was a problem hiding this comment.
This should be included in the installation and is probably extra.
There was a problem hiding this comment.
Should this be worded "should not be included"?
There was a problem hiding this comment.
Yes, sorry. Applies to both comments.
| @@ -1,6 +1,5 @@ | |||
| cherrypy==3.2.4 | |||
| pyaml==15.03.1 | |||
| Jinja2==2.7.3 | |||
| oic==0.7.6 | |||
| yubico-client==1.9.1 | |||
| pyjwkest==1.0.1 | |||
There was a problem hiding this comment.
This should be included in the installation and is probably extra.
|
Merged manually. |
CHANGELOG.md.I don't think this is mergeable, but I don't have the time to clean this up at the moment, particularly the keyjar code. But I thought someone might find this useful since there are issues like #212 and it is mentioned in the main README.
The steps in the README in here took some time to figure out as well, so hopefully that can help some people.
Note that I tested this using Python 3. I did run this under Python 2 and it required a few very bad hacks to get working in the wsgi lib that I think are because start response may have been called twice. I did not dig into that