Mypy #612
Mypy #612
Conversation
|
Hm, the Py34 on Windows is failing for some reason. I am considering dropping the support for Py34 as its EOL is in about a month... @schlenk Any objections? |
|
@tpazderka I don't have objections about dropping Python 3.4 alongside the Python 2.7 drop, its basically the same reasoning. |
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=========================================
- Coverage 60.94% 60.9% -0.04%
=========================================
Files 62 62
Lines 11263 11263
Branches 2005 2005
=========================================
- Hits 6864 6860 -4
- Misses 3831 3835 +4
Partials 568 568
Continue to review full report at Codecov.
|
|
OK, 3.4 removed as well. |
src/oic/oic/provider.py
Outdated
| for endp in self.endp: | ||
| if endp.etype == 'registration': | ||
| endpoint = urljoin(self.baseurl, endp.url) | ||
| DeprecationWarning("Using `register_endpoint` is deprecated, please use " |
There was a problem hiding this comment.
Why only create a DeprecationWarning instance? Shouldn't it be used with warning.warn(...) ?
There was a problem hiding this comment.
Yeah, dumb mistake :)
src/oic/utils/http_util.py
Outdated
| self._srv = server | ||
|
|
||
| srv = property(getServer, setServer) | ||
|
|
||
| def __init__(self, srv, ttl=5, secure=True, httponly=True): | ||
| self.srv = None |
There was a problem hiding this comment.
Why keep this when having the property above?
CHANGELOG.md.