Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed more deprecated code #677

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Removed more deprecated code #677

merged 1 commit into from
Aug 3, 2019

Conversation

tpazderka
Copy link
Collaborator

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #677 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage    62.5%   62.54%   +0.04%     
==========================================
  Files          62       62              
  Lines       11382    11355      -27     
  Branches     2000     1996       -4     
==========================================
- Hits         7114     7102      -12     
+ Misses       3693     3679      -14     
+ Partials      575      574       -1
Impacted Files Coverage Δ
src/oic/utils/http_util.py 69.27% <ø> (+1.29%) ⬆️
src/oic/oic/provider.py 68.12% <ø> (-0.14%) ⬇️
src/oic/utils/authn/client.py 69.41% <ø> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a7d74...fcf78d3. Read the comment docs.

Copy link
Collaborator

@schlenk schlenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CZ-NIC CZ-NIC deleted a comment Aug 3, 2019
@tpazderka tpazderka merged commit 5bdcb68 into master Aug 3, 2019
@tpazderka tpazderka deleted the more_cleanup branch August 3, 2019 19:59
@tpazderka tpazderka restored the more_cleanup branch October 25, 2019 19:51
@tpazderka tpazderka deleted the more_cleanup branch October 25, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants