fix: Function to handle BigInt value in JSON.stringify #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarianoVicenteBA
approved these changes
Sep 24, 2024
|
@nirmal25990 I'd prefer if we didn't have a custom json stringifier function here. |
chris-pardy
reviewed
Sep 30, 2024
| `condition::evaluate <${jsonStringifyWithBigInt(leftHandSideValue)} ${ | ||
| this.operator | ||
| } ${JSON.stringify(rightHandSideValue)}?> (${result})` | ||
| } ${jsonStringifyWithBigInt(rightHandSideValue)}?> (${result})` |
There was a problem hiding this comment.
Let's avoid a custom stringifier here when we can instead rely on the console.log built-in formatter if we change the signature of debug
chris-pardy
added a commit
to chris-pardy/json-rules-engine
that referenced
this pull request
Oct 11, 2024
Change the call signature, leverage built-in formatting on console. Move debug enablement checks to file load. Replaces CacheControl#363 Resolves CacheControl#362 Co-Author Nirmal Patel <nirmal259907@gmail.com>
chris-pardy
added a commit
to chris-pardy/json-rules-engine
that referenced
this pull request
Oct 11, 2024
Change the call signature, leverage built-in formatting on console. Move debug enablement checks to file load. Replaces CacheControl#363 Resolves CacheControl#362 Co-Author Nirmal Patel <nirmal259907@gmail.com>
Merged
|
Replaced by #378 |
chris-pardy
added a commit
to chris-pardy/json-rules-engine
that referenced
this pull request
Oct 15, 2024
Change the call signature, leverage built-in formatting on console. Move debug enablement checks to file load. Replaces CacheControl#363 Resolves CacheControl#362 Co-Author Nirmal Patel <nirmal259907@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.