Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prioritizeAndRun method for performance optimization and readability enhancement #368

Closed
wants to merge 1 commit into from

Conversation

mahendraDV
Copy link

Changes include:

  • Replaced the for loop with a reduce function to iterate over orderedSets, improving code conciseness and maintainability.
  • Moved the stop variable declaration outside the loop to prevent unnecessary reinitialization, enhancing performance.
  • Simplified the loop logic by directly checking for the stopping condition, reducing nesting and improving readability.
  • Removed an unnecessary inner then block, streamlining the code structure.

These modifications ensure that the method continues to evaluate conditions based on the provided operator while improving its performance and maintainability. No functional changes were made.

chris-pardy added a commit to chris-pardy/json-rules-engine that referenced this pull request Oct 11, 2024
Significantly simplify the method by leveraging the short-circuiting of the
|| and && operators.

Replaces CacheControl#368

Co-Author Mahi <dev.babumhndr@gmail.com>
chris-pardy added a commit to chris-pardy/json-rules-engine that referenced this pull request Oct 11, 2024
Significantly simplify the method by leveraging the short-circuiting of the
|| and && operators.

Replaces CacheControl#368

Co-Author Mahi <dev.babumhndr@gmail.com>
@chris-pardy chris-pardy mentioned this pull request Oct 11, 2024
@chris-pardy
Copy link
Collaborator

Replaced by #378

chris-pardy added a commit to chris-pardy/json-rules-engine that referenced this pull request Oct 15, 2024
Significantly simplify the method by leveraging the short-circuiting of the
|| and && operators.

Replaces CacheControl#368

Co-Author Mahi <dev.babumhndr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants