Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at travis-ci code coverage #69

Merged
merged 11 commits into from
Jan 28, 2018
Merged

first pass at travis-ci code coverage #69

merged 11 commits into from
Jan 28, 2018

Conversation

DannyPeck
Copy link
Contributor

No description provided.

xmclark
xmclark previously approved these changes Jan 24, 2018
@xmclark
Copy link
Contributor

xmclark commented Jan 27, 2018

So it seems like cargo-travis is not too well supported anymore, according to this issue huonw/travis-cargo#72. Luckily there is an alternative called cargo-travis. It seems to have feature parity with the deprecated package we use now.

@xmclark
Copy link
Contributor

xmclark commented Jan 27, 2018

alright @DannyPeck @technetos we've got ourselves some sweet code coverage on the coveralls.io.

only thing remaining that I would like to add is a badge, but there is a small issue with that because the branch is hard coded in the url. This causes problems when we merge back to master (someday...). See this: https://stackoverflow.com/questions/18673694/referencing-current-branch-in-github-readme-md.

@xmclark xmclark self-assigned this Jan 27, 2018
@technetos
Copy link
Contributor

lol travis-cargo is dead long live cargo-travis

@DannyPeck
Copy link
Contributor Author

I have found an example of someone using git precommit hooks to modify the badge url: https://gist.github.com/cfont/c0f44703b933c54c9f1b.

@DannyPeck
Copy link
Contributor Author

Here is a tutorial on Git Hooks: https://www.atlassian.com/git/tutorials/git-hooks.

@DannyPeck
Copy link
Contributor Author

Git Hooks are honestly really cool, I think we should look into other possible hooks we could integrate into our project.

# Conflicts:
#	.travis.yml
#	.travis_ci_helper.sh
@DannyPeck
Copy link
Contributor Author

Noting that because I can't approve my own PR, I approve of the changes @xmclark added.

@DannyPeck
Copy link
Contributor Author

Are we still waiting on the addition of precommit badges on this PR?

@technetos
Copy link
Contributor

I believe so yes

@xmclark
Copy link
Contributor

xmclark commented Jan 28, 2018

I think Travis may be able to help us out with post merge readme commit.

@xmclark xmclark merged commit 8a2471d into dev Jan 28, 2018
@xmclark xmclark deleted the issue68-code-coverage branch January 28, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants