-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first pass at travis-ci code coverage #69
Conversation
So it seems like cargo-travis is not too well supported anymore, according to this issue huonw/travis-cargo#72. Luckily there is an alternative called cargo-travis. It seems to have feature parity with the deprecated package we use now. |
# Conflicts: # .travis.yml
alright @DannyPeck @technetos we've got ourselves some sweet code coverage on the coveralls.io. only thing remaining that I would like to add is a badge, but there is a small issue with that because the branch is hard coded in the url. This causes problems when we merge back to master (someday...). See this: https://stackoverflow.com/questions/18673694/referencing-current-branch-in-github-readme-md. |
lol travis-cargo is dead long live cargo-travis |
I have found an example of someone using git precommit hooks to modify the badge url: https://gist.github.com/cfont/c0f44703b933c54c9f1b. |
Here is a tutorial on Git Hooks: https://www.atlassian.com/git/tutorials/git-hooks. |
Git Hooks are honestly really cool, I think we should look into other possible hooks we could integrate into our project. |
# Conflicts: # .travis.yml # .travis_ci_helper.sh
Noting that because I can't approve my own PR, I approve of the changes @xmclark added. |
Are we still waiting on the addition of precommit badges on this PR? |
I believe so yes |
I think Travis may be able to help us out with post merge readme commit. |
No description provided.