Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cadquery shouldn't install tests #181

Closed
l29ah opened this issue Aug 18, 2019 · 2 comments · Fixed by #478
Closed

Cadquery shouldn't install tests #181

l29ah opened this issue Aug 18, 2019 · 2 comments · Fixed by #478

Comments

@l29ah
Copy link
Contributor

l29ah commented Aug 18, 2019

Users don't need them, also Gentoo's build system is pissed:

 *   Package installs 'tests' package which is forbidden and likely a bug in the build system.
@adam-urbanczyk
Copy link
Member

I never used Gentoo, so I am not sure how to interpret what you pasted. Are you referring to this line maybe?

packages=['cadquery','cadquery.contrib','cadquery.occ_impl','cadquery.plugins','tests'],

If so, it is indeed sub-optimal. I don't really agree with the broad statement that "cadquery shouldn't install tests" . We should probably move them to cadquery.tests though.

@l29ah
Copy link
Contributor Author

l29ah commented Aug 18, 2019

Yeah, that's the problem it complains about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants