Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin NthSelector #517

Closed
marcus7070 opened this issue Nov 21, 2020 · 0 comments · Fixed by #549
Closed

Mixin NthSelector #517

marcus7070 opened this issue Nov 21, 2020 · 0 comments · Fixed by #549
Labels
enhancement New feature or request selectors

Comments

@marcus7070
Copy link
Member

While working on RadiusNthSelector in #504 I duplicated a fair bit of code from DirectionNthSelector. I think it would be worth creating a MixinNthSelector class to hold this code and be a parent for RadiusNthSelector, DirectionNthSelector, and for a potential LengthNthSelector.
@adam-urbanczyk adam-urbanczyk added selectors enhancement New feature or request labels Nov 27, 2020
This was referenced Dec 4, 2020
Closed
Merged
marcus7070 added a commit to marcus7070/cadquery that referenced this issue Dec 18, 2020
@marcus7070
Refactored selectors
0a6507d 
Added NthSelector abstract class and refactored RadiusNthSelector,
DirectionMinMaxSelector and DirectionNthSelector. Closes CadQuery#517.
marcus7070 added a commit to marcus7070/cadquery that referenced this issue Dec 18, 2020
@marcus7070
Refactored selectors
6d2f3ba 
Added NthSelector abstract class and refactored RadiusNthSelector,
DirectionMinMaxSelector and DirectionNthSelector. Closes CadQuery#517.
@marcus7070 marcus7070 mentioned this issue Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request selectors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor selectors and add CenterNthSelector marcus7070/cadquery
2 participants
@adam-urbanczyk @marcus7070